mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Review Request 45590: Made `Delegate` and `Handlers` libprocess tests less fragile.
Date Fri, 01 Apr 2016 16:22:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45590/
-----------------------------------------------------------

Review request for mesos and Ben Mahler.


Repository: mesos


Description
-------

As previously written, these tests depended on the fact that `post`
will synchronously deliver a message to a local PID.  That is an
implementation detail that seems unwise to rely upon. Instead, it is
quite easy to arrange for both tests to block until the effect of
the `post` has occurred.


Diffs
-----

  3rdparty/libprocess/src/tests/process_tests.cpp 6b3aa1bcf20466cdf8f8249988b8b06dec27e5cd


Diff: https://reviews.apache.org/r/45590/diff/


Testing
-------

make check

Without this patch, the libprocess tests fail if the "local message" short-circuit in `transport`
is disabled (circa line 556). With the patch, the tests succeed.


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message