mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 45039: Updated the comment for launching tasks and accepting offers.
Date Fri, 01 Apr 2016 14:53:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45039/#review126586
-----------------------------------------------------------




docs/app-framework-development-guide.md (line 184)
<https://reviews.apache.org/r/45039/#comment189599>

    Here and below, I would personally rephrase this slightly.
    
    "Any remaining resources remaining (i.e., those that are not used by the launched tasks
or their executors) will be considered unused. Note that this includes resources used by tasks
that the framework attempted to launch but failed (with TASK_ERROR) due to a malformed task
description."


- Neil Conway


On April 1, 2016, 2:14 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45039/
> -----------------------------------------------------------
> 
> (Updated April 1, 2016, 2:14 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If the task does not pass validation,
> its resources are considered declined.
> 
> 
> Diffs
> -----
> 
>   docs/app-framework-development-guide.md 1d8bebde67f69fd414509b8861571137d3569b46 
>   include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54 
>   src/java/src/org/apache/mesos/SchedulerDriver.java bf866f5ebece2505eaa27bf39a1382cd1a2a069a

>   src/python/interface/src/mesos/interface/__init__.py 232890daa6d222ae1c86906bbc484c8e635c4eb7

> 
> Diff: https://reviews.apache.org/r/45039/diff/
> 
> 
> Testing
> -------
> 
> None: not a functional change.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message