mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 45082: Implemented cleanup() method of "network/cni" isolator.
Date Fri, 01 Apr 2016 09:55:31 GMT


> On April 1, 2016, 6:22 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 781
> > <https://reviews.apache.org/r/45082/diff/9/?file=1320746#file1320746line781>
> >
> >     Can you add some LOG(INFO) here. Maybe in a subsequent patch.

Sure, fixed it in a new patch: https://reviews.apache.org/r/45580/


> On April 1, 2016, 6:22 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 788
> > <https://reviews.apache.org/r/45082/diff/9/?file=1320746#file1320746line788>
> >
> >     Ditto on adding some LOG(INFO) here.

Ditto.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45082/#review126475
-----------------------------------------------------------


On March 31, 2016, 7:28 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45082/
> -----------------------------------------------------------
> 
> (Updated March 31, 2016, 7:28 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
>     https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented cleanup() method of "network/cni" isolator.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 873e0c52475f4868e611bd24a6782ad5eb261a99

>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 1c8e231813c0579b79681c5d18b1f799a727ead7

> 
> Diff: https://reviews.apache.org/r/45082/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message