mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Deshi Xiao <xia...@gmail.com>
Subject Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.
Date Fri, 01 Apr 2016 05:07:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45500/
-----------------------------------------------------------

(Updated 四月 1, 2016, 5:07 a.m.)


Review request for mesos, haosdent huang and Cong Wang.


Bugs: MESOS-1104
    https://issues.apache.org/jira/browse/MESOS-1104


Repository: mesos


Description
-------

other exists code under src/linux/, e.g. perf.hpp, ns.hpp
I think remove mesos::internal:: should be enough.


Diffs
-----

  src/linux/cgroups.cpp b7420c682970c4838e84973198ac4fe7af5f68f9 
  src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 
  src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 
  src/slave/containerizer/mesos/mount.cpp bf17b015e45579882fd31248e8609eec6d58a9da 
  src/tests/containerizer/fs_tests.cpp 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 
  src/tests/containerizer/port_mapping_tests.cpp e062daa9fcfc776144b48325daa1f1284c5e59a4


Diff: https://reviews.apache.org/r/45500/diff/


Testing
-------

will testing on Linux(ubuntu,centos)


File Attachments (updated)
----------------

cgroups.cpp
  https://reviews.apache.org/media/uploaded/files/2016/04/01/c782c054-1e37-4f92-ae03-55841eca9c05__cgroups.cpp


Thanks,

Deshi Xiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message