mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.
Date Fri, 01 Apr 2016 03:05:46 GMT


> On April 1, 2016, 2:53 a.m., fan du wrote:
> > src/linux/perf.cpp, line 354
> > <https://reviews.apache.org/r/43283/diff/2/?file=1321758#file1321758line354>
> >
> >     Why did you implement the idea I worked out at https://issues.apache.org/jira/browse/MESOS-4705
by updating your orignal approach
> >     at the condition you are in the MESOS-4705 converstaion as well, and you know
well I'm working on the same issue?

Hi, @fan.du This is a dependency patch I submit serveral months ago(I think should be ealier
before you?).

After look your tickets, it is totally OK for me to don't sumbit this eventually. And because
I want to local test [MESOS-5047](https://issues.apache.org/jira/browse/MESOS-5047) in my
machine. I have to apply this to avoid it check failed in my machine. I already update the
description to clarify this.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43283/#review126516
-----------------------------------------------------------


On April 1, 2016, 2:09 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43283/
> -----------------------------------------------------------
> 
> (Updated April 1, 2016, 2:09 a.m.)
> 
> 
> Review request for mesos, Ian Downes, Jan Schlicht, and Paul Brett.
> 
> 
> Bugs: MESOS-4655
>     https://issues.apache.org/jira/browse/MESOS-4655
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.
> 
> 
> Diffs
> -----
> 
>   src/linux/perf.cpp 749e676aaf2ce639dd976f2b23e323300c6114c5 
> 
> Diff: https://reviews.apache.org/r/43283/diff/
> 
> 
> Testing
> -------
> 
> This also fix similar error in `CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf`.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message