From reviews-return-29241-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Mar 31 02:03:15 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B83851923A for ; Thu, 31 Mar 2016 02:03:15 +0000 (UTC) Received: (qmail 64372 invoked by uid 500); 31 Mar 2016 02:03:15 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 64343 invoked by uid 500); 31 Mar 2016 02:03:15 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 64326 invoked by uid 99); 31 Mar 2016 02:03:15 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 31 Mar 2016 02:03:15 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6E98E28F629; Thu, 31 Mar 2016 02:03:13 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8864253966071447689==" MIME-Version: 1.0 Subject: Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1. From: Jie Yu To: Adam B , haosdent huang , Jiang Yan Xu , Greg Mann Cc: Jie Yu , Deshi Xiao , mesos Date: Thu, 31 Mar 2016 02:03:13 -0000 Message-ID: <20160331020313.5121.92274@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jie Yu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/45474/ X-Sender: Jie Yu References: <20160330081347.5121.12959@reviews.apache.org> In-Reply-To: <20160330081347.5121.12959@reviews.apache.org> Reply-To: Jie Yu X-ReviewRequest-Repository: mesos --===============8864253966071447689== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45474/#review126242 ----------------------------------------------------------- This is a high level question: I am now sure if adding attributes is safe or not. For instance, my framework has the following rule: only schedule tasks to agents that do not have attribute "not_safe". Now, say agent A is initially without that attribute. My framework lands several tasks on that agent. Later, when agent restarts, the operator adds the new attribute "not_safe". Suddently, i have tasks running on unsafe boxes. oops. - Jie Yu On March 30, 2016, 8:13 a.m., Deshi Xiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45474/ > ----------------------------------------------------------- > > (Updated March 30, 2016, 8:13 a.m.) > > > Review request for mesos, Adam B, Greg Mann, haosdent huang, and Jiang Yan Xu. > > > Bugs: MESOS-1739 > https://issues.apache.org/jira/browse/MESOS-1739 > > > Repository: mesos > > > Description > ------- > > Phase 1 > Make SlaveInfo mutable throughout the stack, and allow for expansion of resources and attributes only (Which allows testing to make sure it propagates to the allocator, shows up in offers, etc). Ensure there is unified checking for incompatibilities in both the slave and master (the slave should validate the config, the master should validate that all operations the slave takes are legal). > > it derived from another PR(https://reviews.apache.org/r/25525/) > > > Diffs > ----- > > src/tests/slave_tests.cpp 1f1a31020096efa5db698e86ac74e61dfdb4b94a > > Diff: https://reviews.apache.org/r/45474/diff/ > > > Testing > ------- > > make check on localhost > > > Thanks, > > Deshi Xiao > > --===============8864253966071447689==--