From reviews-return-29198-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Mar 30 18:10:19 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B946319F02 for ; Wed, 30 Mar 2016 18:10:19 +0000 (UTC) Received: (qmail 94206 invoked by uid 500); 30 Mar 2016 18:10:19 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 94179 invoked by uid 500); 30 Mar 2016 18:10:19 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 94165 invoked by uid 99); 30 Mar 2016 18:10:19 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Mar 2016 18:10:19 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7CE942914A3; Wed, 30 Mar 2016 18:10:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5930493110963372085==" MIME-Version: 1.0 Subject: Re: Review Request 45471: Fix a test case bug due to upgrade http-parser to 2.6.1. From: Greg Mann To: Vinod Kone , Greg Mann Cc: Zhiwei Chen , mesos Date: Wed, 30 Mar 2016 18:10:16 -0000 Message-ID: <20160330181016.23781.61963@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Greg Mann X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/45471/ X-Sender: Greg Mann References: <20160330053502.30712.38927@reviews.apache.org> In-Reply-To: <20160330053502.30712.38927@reviews.apache.org> Reply-To: Greg Mann X-ReviewRequest-Repository: mesos --===============5930493110963372085== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45471/#review126160 ----------------------------------------------------------- This could break existing clients which include extra whitespace, though it does seem that RFC-7230 specifically prohibits whitespace in that location. I wonder if a deprecation cycle is advisable for this change? Also, it's not immediately clear to me: are we using http-parser in "strict" mode? - Greg Mann On March 30, 2016, 5:35 a.m., Zhiwei Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45471/ > ----------------------------------------------------------- > > (Updated March 30, 2016, 5:35 a.m.) > > > Review request for mesos, Greg Mann and Vinod Kone. > > > Bugs: MESOS-5063 > https://issues.apache.org/jira/browse/MESOS-5063 > > > Repository: mesos > > > Description > ------- > > Fix a test case bug due to upgrade http-parser to 2.6.1. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/ssl_tests.cpp 53a0ed03226030104af43a45c6ccfbfc0f4b7e9f > > Diff: https://reviews.apache.org/r/45471/diff/ > > > Testing > ------- > > ../configure --enable-libevent --enable-ssl > > sudo make dist check > > > Thanks, > > Zhiwei Chen > > --===============5930493110963372085==--