From reviews-return-29184-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Mar 30 15:24:17 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9B6311965B for ; Wed, 30 Mar 2016 15:24:17 +0000 (UTC) Received: (qmail 18023 invoked by uid 500); 30 Mar 2016 15:24:17 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 17996 invoked by uid 500); 30 Mar 2016 15:24:17 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 17980 invoked by uid 99); 30 Mar 2016 15:24:17 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Mar 2016 15:24:17 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D9890291083; Wed, 30 Mar 2016 15:24:14 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0015320483620754715==" MIME-Version: 1.0 Subject: Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1. From: Mesos ReviewBot To: Adam B , haosdent huang , Jiang Yan Xu , Greg Mann Cc: Mesos ReviewBot , Deshi Xiao , mesos Date: Wed, 30 Mar 2016 15:24:14 -0000 Message-ID: <20160330152414.5121.47192@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos ReviewBot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/45474/ X-Sender: Mesos ReviewBot References: <20160330081347.5121.12959@reviews.apache.org> In-Reply-To: <20160330081347.5121.12959@reviews.apache.org> Reply-To: Mesos ReviewBot X-ReviewRequest-Repository: mesos --===============0015320483620754715== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45474/#review126118 ----------------------------------------------------------- Patch looks great! Reviews applied: [45474] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On March 30, 2016, 8:13 a.m., Deshi Xiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45474/ > ----------------------------------------------------------- > > (Updated March 30, 2016, 8:13 a.m.) > > > Review request for mesos, Adam B, Greg Mann, haosdent huang, and Jiang Yan Xu. > > > Bugs: MESOS-1739 > https://issues.apache.org/jira/browse/MESOS-1739 > > > Repository: mesos > > > Description > ------- > > Phase 1 > Make SlaveInfo mutable throughout the stack, and allow for expansion of resources and attributes only (Which allows testing to make sure it propagates to the allocator, shows up in offers, etc). Ensure there is unified checking for incompatibilities in both the slave and master (the slave should validate the config, the master should validate that all operations the slave takes are legal). > > it derived from another PR(https://reviews.apache.org/r/25525/) > > > Diffs > ----- > > src/tests/slave_tests.cpp 1f1a31020096efa5db698e86ac74e61dfdb4b94a > > Diff: https://reviews.apache.org/r/45474/diff/ > > > Testing > ------- > > make check on localhost > > > Thanks, > > Deshi Xiao > > --===============0015320483620754715==--