From reviews-return-28885-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Mar 28 18:18:19 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9095B1965C for ; Mon, 28 Mar 2016 18:18:19 +0000 (UTC) Received: (qmail 16808 invoked by uid 500); 28 Mar 2016 18:18:19 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 16782 invoked by uid 500); 28 Mar 2016 18:18:19 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 16768 invoked by uid 99); 28 Mar 2016 18:18:18 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Mar 2016 18:18:18 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 656FA28F2A5; Mon, 28 Mar 2016 18:18:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4294151598542119511==" MIME-Version: 1.0 Subject: Re: Review Request 45122: Updated tests for deletion of persistent volumes. From: Jie Yu To: Jie Yu , Joris Van Remoortere Cc: Neil Conway , mesos Date: Mon, 28 Mar 2016 18:18:16 -0000 Message-ID: <20160328181816.30712.10860@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jie Yu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/45122/ X-Sender: Jie Yu References: <20160326005340.6937.93115@reviews.apache.org> In-Reply-To: <20160326005340.6937.93115@reviews.apache.org> Reply-To: Jie Yu X-ReviewRequest-Repository: mesos --===============4294151598542119511== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On March 26, 2016, 12:53 a.m., Jie Yu wrote: > > src/tests/persistent_volume_tests.cpp, line 810 > > > > > > What the purpose of adding another file here? > > Neil Conway wrote: > I wanted to check that if files are directly written into the directory that corresponds to the persistent volume (not via the task itself), they are still cleaned up when the volume is destroyed. > > Jie Yu wrote: > hum, I still don't understand. What's the purpose of this test? to simulate what situation? > > Neil Conway wrote: > The situation I wanted to test is that you have a directory `/foo` that is being used by a Mesos task as a persistent volume. Another process on the box writes a file `/foo/bar`, and then the Mesos task terminates and the volume is destroyed. The test checks that `/foo/bar` is removed, even though it wasn't created by the Mesos task. > > Jie Yu wrote: > I understand what it is doing. I don't understand is: is this a legitimate use case? You mean some out of band process is writing the persistent volume? This does not fit well with the Mesos model, isn't it? I would suggest we don't add those. > > Neil Conway wrote: > Well, we're already testing whether an out-of-band process can read from the persistent volume (for `filePath1`), so it seemed natural to test writing to it as well -- happy to remove it if you'd prefer though. I think the 'read' is to make sure the file written by the task is actually persisted in the persistent volume. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45122/#review125499 ----------------------------------------------------------- On March 28, 2016, 4:07 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45122/ > ----------------------------------------------------------- > > (Updated March 28, 2016, 4:07 p.m.) > > > Review request for mesos, Jie Yu and Joris Van Remoortere. > > > Bugs: MESOS-2408 > https://issues.apache.org/jira/browse/MESOS-2408 > > > Repository: mesos > > > Description > ------- > > Updated tests for deletion of persistent volumes. > > > Diffs > ----- > > src/tests/persistent_volume_tests.cpp 26fff19daa8b175fdcc06fd9467224d5920a1967 > > Diff: https://reviews.apache.org/r/45122/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Neil Conway > > --===============4294151598542119511==--