From reviews-return-28592-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Mar 24 17:33:50 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0982319B70 for ; Thu, 24 Mar 2016 17:33:50 +0000 (UTC) Received: (qmail 33229 invoked by uid 500); 24 Mar 2016 17:33:50 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 33202 invoked by uid 500); 24 Mar 2016 17:33:50 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 33172 invoked by uid 99); 24 Mar 2016 17:33:49 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Mar 2016 17:33:49 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5DF1E28C226; Thu, 24 Mar 2016 17:33:48 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9214062470211757615==" MIME-Version: 1.0 Subject: Re: Review Request 37168: Add an example framework using dynamic reservation. From: Mesos ReviewBot To: Joerg Schad , Michael Park , Greg Mann Cc: Mesos ReviewBot , Klaus Ma , mesos Date: Thu, 24 Mar 2016 17:33:48 -0000 Message-ID: <20160324173348.6937.19362@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos ReviewBot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/37168/ X-Sender: Mesos ReviewBot References: <20160322034437.6937.78272@reviews.apache.org> In-Reply-To: <20160322034437.6937.78272@reviews.apache.org> X-ReviewBoard-Diff-For: src/tests/dynamic_reservation_framework_test.sh X-ReviewBoard-Diff-For: src/examples/dynamic_reservation_framework.cpp Reply-To: Mesos ReviewBot X-ReviewRequest-Repository: mesos --===============9214062470211757615== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review125297 ----------------------------------------------------------- Patch looks great! Reviews applied: [37168] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On March 22, 2016, 3:44 a.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37168/ > ----------------------------------------------------------- > > (Updated March 22, 2016, 3:44 a.m.) > > > Review request for mesos, Greg Mann, Joerg Schad, and Michael Park. > > > Bugs: MESOS-3063 > https://issues.apache.org/jira/browse/MESOS-3063 > > > Repository: mesos > > > Description > ------- > > Provide example for dynamic reservation features. > > > Diffs > ----- > > src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf > src/examples/dynamic_reservation_framework.cpp PRE-CREATION > src/tests/dynamic_reservation_framework_test.sh PRE-CREATION > src/tests/examples_tests.cpp 6ddac17bb2ac0330bcc09eaab975ae70e84a7695 > > Diff: https://reviews.apache.org/r/37168/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Klaus Ma > > --===============9214062470211757615==--