From reviews-return-28277-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Mar 22 15:32:40 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DF59A18A4B for ; Tue, 22 Mar 2016 15:32:40 +0000 (UTC) Received: (qmail 83469 invoked by uid 500); 22 Mar 2016 15:32:40 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 83442 invoked by uid 500); 22 Mar 2016 15:32:40 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 83426 invoked by uid 99); 22 Mar 2016 15:32:40 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Mar 2016 15:32:40 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6FE3A1DB692; Tue, 22 Mar 2016 15:32:39 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6149355586559293083==" MIME-Version: 1.0 Subject: Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation. From: Greg Mann To: Jie Yu , Greg Mann , Guangya Liu , haosdent huang Cc: fan du , mesos Date: Tue, 22 Mar 2016 15:32:39 -0000 Message-ID: <20160322153239.19594.94460@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Greg Mann X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/44255/ X-Sender: Greg Mann X-ReviewBoard-ShipIt: 1 References: <20160314055006.26510.12510@reviews.apache.org> In-Reply-To: <20160314055006.26510.12510@reviews.apache.org> Reply-To: Greg Mann X-ReviewRequest-Repository: mesos --===============6149355586559293083== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/#review124811 ----------------------------------------------------------- Fix it, then Ship it! src/master/master.cpp (line 3028) Blank line after this? - Greg Mann On March 14, 2016, 5:50 a.m., fan du wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44255/ > ----------------------------------------------------------- > > (Updated March 14, 2016, 5:50 a.m.) > > > Review request for mesos, Greg Mann, Guangya Liu, haosdent huang, and Jie Yu. > > > Bugs: MESOS-4492 > https://issues.apache.org/jira/browse/MESOS-4492 > > > Repository: mesos > > > Description > ------- > > Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation. > > > Diffs > ----- > > docs/monitoring.md 323d01d99456a71bd384faf186264e3fc4bf2207 > src/master/http.cpp 950206baf7f3a1cccdc49d810126473966d8d021 > src/master/master.cpp 8d6d3c6468c6b85fe09c33cf9747cc3d1f515ab9 > src/master/metrics.hpp 9d201fcce1c46a890c86a889ab31029f9a061561 > src/master/metrics.cpp 30c091198a8fdd6d6a957a351dc37d3dae7788e4 > src/tests/metrics_tests.cpp 419d275e0b32817388120222bd433ee6f4835efd > > Diff: https://reviews.apache.org/r/44255/diff/ > > > Testing > ------- > > ChangLog: > > v3: > - Move the couting out of common code path to http endpoint and master accept call separately to reflect its logic. > > v2: > - Documenting those metrics > - Add test code for MetricsTest as suggested by Guangya > - post-review.py does not update original RR(https://reviews.apache.org/r/44058/), but only create a new one even if I rebased. > > > Tests: > 1. make check GTEST_FILTER="MetricsTest.Master" on Centos-7 (3.10.0-123.el7.x86_640) > > [==========] Running 1 test from 1 test case. > [----------] Global test environment set-up. > [----------] 1 test from MetricsTest > [ RUN ] MetricsTest.Master > [ OK ] MetricsTest.Master (211 ms) > [----------] 1 test from MetricsTest (211 ms total) > > [----------] Global test environment tear-down > [==========] 1 test from 1 test case ran. (244 ms total) > [ PASSED ] 1 test > > 2. Verify its functionality with 'reserve' http endpoint as an test case > > # curl http://ipdc02-kvm-guest2:5050/metrics/snapshot | python -mjson.tool | grep reserve > "master/messages_reserve_resource": 0.0, > "master/messages_unreserve_resource": 0.0, > > > # curl -i -d slaveId=6250553a-2f39-4a92-9073-4618d130f433-S1 -d resources='[ { "name": "cpus", "type": "SCALAR","scalar": { "value": 1 },"reservation":{"principal": "XiaoHaHa"}} ]' -X POST ipdc02-kvm-guest2:5050/master/reserve > HTTP/1.1 200 OK > Date: Fri, 26 Feb 2016 19:59:01 GMT > Content-Length: 0 > > # curl http://ipdc02-kvm-guest2:5050/metrics/snapshot | python -mjson.tool | grep reserve > "master/messages_reserve_resource": 1.0, > "master/messages_unreserve_resource": 0.0, > > > Thanks, > > fan du > > --===============6149355586559293083==--