From reviews-return-26648-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Mar 11 01:37:14 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7160918FB2 for ; Fri, 11 Mar 2016 01:37:14 +0000 (UTC) Received: (qmail 47824 invoked by uid 500); 11 Mar 2016 01:37:14 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 47800 invoked by uid 500); 11 Mar 2016 01:37:14 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 47775 invoked by uid 99); 11 Mar 2016 01:37:14 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Mar 2016 01:37:14 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BD8672AB167; Fri, 11 Mar 2016 01:37:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3341228235083517456==" MIME-Version: 1.0 Subject: Review Request 44694: Enabled multiple calls to ModuleManager::load(). From: Kapil Arya To: Joris Van Remoortere , Michael Park , Till Toenshoff Cc: mesos Date: Fri, 11 Mar 2016 01:37:12 -0000 Message-ID: <20160311013712.28009.79726@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Kapil Arya X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/44694/ X-Sender: Kapil Arya Reply-To: Kapil Arya X-ReviewRequest-Repository: mesos --===============3341228235083517456== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44694/ ----------------------------------------------------------- Review request for mesos, Joris Van Remoortere, Michael Park, and Till Toenshoff. Bugs: MESOS-4903 https://issues.apache.org/jira/browse/MESOS-4903 Repository: mesos Description ------- As long as the module(s) being loaded don't conflict with the already loaded modules, the module manager will allow multiple calls to `load()`. Diffs ----- include/mesos/type_utils.hpp 27fa8c9256c24b5ec6f5d259305ea66b5f556673 src/common/type_utils.cpp 037c4336276258d671d0b1bf66cdab50b5bf9fb8 src/module/manager.hpp 89dd06097a355c6455e8f8af7d3d98847a304c90 src/module/manager.cpp 6ae99504005581b22a44768949b1d305cec517d9 src/tests/module_tests.cpp 497ed87bddce23bb457373da40dc87111c04136d Diff: https://reviews.apache.org/r/44694/diff/ Testing ------- Added new tests and ran make check. Thanks, Kapil Arya --===============3341228235083517456==--