From reviews-return-25640-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Mar 2 19:08:40 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1F66A18523 for ; Wed, 2 Mar 2016 19:08:40 +0000 (UTC) Received: (qmail 23860 invoked by uid 500); 2 Mar 2016 19:08:40 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 23826 invoked by uid 500); 2 Mar 2016 19:08:39 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 23808 invoked by uid 99); 2 Mar 2016 19:08:39 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Mar 2016 19:08:39 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1A51B2E7B39; Wed, 2 Mar 2016 19:08:39 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4904715414165652302==" MIME-Version: 1.0 Subject: Review Request 44278: Added HTTP scheduler stream IDs. From: Greg Mann To: Anand Mazumdar , Vinod Kone Cc: Greg Mann , mesos Date: Wed, 02 Mar 2016 19:08:39 -0000 Message-ID: <20160302190839.1649.38438@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Greg Mann X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/44278/ X-Sender: Greg Mann Reply-To: Greg Mann X-ReviewRequest-Repository: mesos --===============4904715414165652302== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44278/ ----------------------------------------------------------- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-3583 https://issues.apache.org/jira/browse/MESOS-3583 Repository: mesos Description ------- Added HTTP scheduler stream IDs. In some failure scenarios involving highly-available HTTP schedulers with multiple instances, it's possible for a non-leading instance to successfully make HTTP calls to the master. This patch enables the master to use HTTP scheduler stream IDs to uniquely identify each HTTP subscription stream, preventing any non-leading scheduler instance from making calls to the master. The patch also adds stream ID support to the HTTP scheduler library. Three new tests have been added in this patch: SchedulerHttpApiTest.TeardownWithoutStreamId, SchedulerHttpApiTest.TeardownWrongStreamId, SchedulerHttpApiTest.SubscribeWithStreamId Diffs ----- src/master/http.cpp 5e9e28e904ba0045ee27eb828f47231632a91d74 src/master/master.hpp 13c6ff153e77c527822309e787942eb463d59e7d src/scheduler/scheduler.cpp 7ea1c2567f37a73160bca346a25bb2f0c54e71a0 src/tests/scheduler_http_api_tests.cpp 428e12646d80b45daec30cfe607b97f36170fdf5 Diff: https://reviews.apache.org/r/44278/diff/ Testing ------- New tests were added, and `make check` was used to test on OSX. The new tests were run 1000 times to check for flakiness; no failures were observed. Thanks, Greg Mann --===============4904715414165652302==--