From reviews-return-25600-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Mar 2 14:02:24 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1A44218240 for ; Wed, 2 Mar 2016 14:02:24 +0000 (UTC) Received: (qmail 37960 invoked by uid 500); 2 Mar 2016 14:02:23 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 37899 invoked by uid 500); 2 Mar 2016 14:02:21 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 37339 invoked by uid 99); 2 Mar 2016 14:02:20 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Mar 2016 14:02:20 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BA91A2AA451; Wed, 2 Mar 2016 14:02:20 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3748576332747504823==" MIME-Version: 1.0 Subject: Re: Review Request 44254: Add curl_easy_cleanup when fopen is failed. From: Mesos ReviewBot To: Jie Yu , Vinod Kone Cc: Mesos ReviewBot , Andy Pang , mesos Date: Wed, 02 Mar 2016 14:02:20 -0000 Message-ID: <20160302140220.1649.21365@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos ReviewBot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/44254/ X-Sender: Mesos ReviewBot References: <20160302062152.26940.37194@reviews.apache.org> In-Reply-To: <20160302062152.26940.37194@reviews.apache.org> Reply-To: Mesos ReviewBot X-ReviewRequest-Repository: mesos --===============3748576332747504823== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44254/#review121640 ----------------------------------------------------------- Patch looks great! Reviews applied: [44254] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On March 2, 2016, 6:21 a.m., Andy Pang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44254/ > ----------------------------------------------------------- > > (Updated March 2, 2016, 6:21 a.m.) > > > Review request for mesos, Jie Yu and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > When fopen is failed,we should curl_easy_cleanup curl_handle and close fd > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 3c80910 > > Diff: https://reviews.apache.org/r/44254/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Andy Pang > > --===============3748576332747504823==--