From reviews-return-25549-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Mar 2 06:15:03 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 818FA1859B for ; Wed, 2 Mar 2016 06:15:03 +0000 (UTC) Received: (qmail 89929 invoked by uid 500); 2 Mar 2016 06:15:03 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 89900 invoked by uid 500); 2 Mar 2016 06:15:03 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 89882 invoked by uid 99); 2 Mar 2016 06:15:02 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Mar 2016 06:15:02 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id CF5682E77A5; Wed, 2 Mar 2016 06:15:01 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3544150107559870854==" MIME-Version: 1.0 Subject: Re: Review Request 43889: CMake: Add leveldb library to 3rdparty external builds. From: Diana Arroyo To: Joris Van Remoortere , Alex Clemmer , Artem Harutyunyan , Joseph Wu , Till Toenshoff Cc: Mesos ReviewBot , mesos , Diana Arroyo , haosdent huang Date: Wed, 02 Mar 2016 06:15:01 -0000 Message-ID: <20160302061501.26941.90544@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Diana Arroyo X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/43889/ X-Sender: Diana Arroyo References: <20160302005214.26941.29039@reviews.apache.org> In-Reply-To: <20160302005214.26941.29039@reviews.apache.org> X-ReviewBoard-Diff-For: 3rdparty/leveldb.patch X-ReviewBoard-Diff-For: 3rdparty/leveldb-1.4.patch X-ReviewBoard-Diff-For: 3rdparty/leveldb-1.4.tar.gz X-ReviewBoard-Diff-For: 3rdparty/leveldb.tar.gz Reply-To: Diana Arroyo X-ReviewRequest-Repository: mesos --===============3544150107559870854== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43889/ ----------------------------------------------------------- (Updated March 2, 2016, 6:15 a.m.) Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, Joseph Wu, and Till Toenshoff. Changes ------- More changes to handle rename in automake of leveldb to leveldb-1.4. Bugs: MESOS-4746 https://issues.apache.org/jira/browse/MESOS-4746 Repository: mesos Description ------- CMake: Add leveldb library to 3rdparty external builds. Diffs (updated) ----- 3rdparty/CMakeLists.txt 68020dca6a4ea9790c9a54e5e33aa47674581a58 3rdparty/Makefile.am 3782583b7683d9d3bb61e7e8a1953bc3f61055f0 3rdparty/cmake/Mesos3rdpartyConfigure.cmake aaf1651e155b27a4f2cb72b4586d0d3d94a95b11 3rdparty/cmake/Versions.cmake 932f2f66b04e5ca3d2ed04da1e7019d2ff7488e4 3rdparty/leveldb-1.4.tar.gz PRE-CREATION 3rdparty/leveldb.patch 3rdparty/leveldb.tar.gz b6ea2c7df8f0eef687f9ad90af70f35f81743cbc 3rdparty/versions.am 3f4513d960901bc0c014cc7ca148bf5bd43f5995 LICENSE c3aaa437af10533132698df3348114195d338965 src/Makefile.am 5d8fe8bf33acb352589b2b3e0341987f9a41bc17 src/python/native/ext_modules.py.in 4682e5eed0f7be23fb48ef628e1bebc7741431d7 src/slave/cmake/SlaveConfigure.cmake 5697a0bfa52e8ea15563bc0668ec63aadbb01ed3 Diff: https://reviews.apache.org/r/43889/diff/ Testing ------- Tested on Ubuntu. Thanks, Diana Arroyo --===============3544150107559870854==--