mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 44379: Correctly parse perf stat format for non-vanilla 3.10 kernel.
Date Thu, 17 Mar 2016 01:04:01 GMT
Hey Fan,

Left some comments, mostly I'm a bit confused by your comment that OS
vendors can tweak the format. How did you know they only tweak it that
particular way?

Ben

On Wed, Mar 9, 2016 at 11:53 PM, Mesos ReviewBot <reviews@mesos.apache.org>
wrote:

> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44379/
>
> Patch looks great!
>
> Reviews applied: [44379]
>
> Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1
MESOS_VERBOSE=1'; ./support/docker_build.sh
>
>
> - Mesos ReviewBot
>
> On March 10th, 2016, 3:26 a.m. UTC, fan du wrote:
> Review request for mesos and Ben Mahler.
> By fan du.
>
> *Updated March 10, 2016, 3:26 a.m.*
> *Bugs: * MESOS-4705 <https://issues.apache.org/jira/browse/MESOS-4705>
> *Repository: * mesos
> Description
>
> For vanilla kernel <= 3.12, 'perf stat' format is:
>   value,event,cgroup
> Tested with 3.12, 3.11, 3.10 vanilla kernel.
>
> OS vendors may enhance perf tools with additional format:
>   value,unit,event,cgroup,running,ratio
> Tested on Centos 7 with kernel 3.10.0-{123 OR 229}.el7.x86_64
>
> Testing
>
>
>    1. {Found and Test} with Serenity, ema filter could get perf event statistics correctly
as expected.
>    2. ./bin/mesos-tests.sh --gtest_filter=PerfEventIsolatorTest* --log_dir=/tmp/mesos/
>
> Diffs
>
>    - src/linux/perf.cpp (1c113a2b3f57877e132bbd65e01fb2f045132128)
>
> View Diff <https://reviews.apache.org/r/44379/diff/>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message