mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jojy Varghese <j...@mesosphere.io>
Subject Re: Review Request 44230: Added FS_DEFAULT case in rmdir.
Date Tue, 15 Mar 2016 22:33:11 GMT
Would be happy to add test. Patch forthcoming. Will also address FTS_SLNONE.

-Jojy


> On Mar 15, 2016, at 2:26 PM, David Robinson <drobinson@twopensource.com> wrote:
> 
> 
> 
>> On March 15, 2016, 8:02 p.m., Neil Conway wrote:
>>> Is it feasible/portable to have a test case for this change?
>> 
>> Cong Wang wrote:
>>    Yes, like in our case, you can create some socket or device file and try to remove
the directory contains it, it would fail without this patch.
> 
> AFAICT tests have already been added:
> 
> https://github.com/apache/mesos/commit/c55ca2941b0119c13764bccdebcea46119e69e4e
> 
> 
> - David
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44230/#review123733
> -----------------------------------------------------------
> 
> 
> On March 1, 2016, 10:01 p.m., Jojy Varghese wrote:
>> 
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/44230/
>> -----------------------------------------------------------
>> 
>> (Updated March 1, 2016, 10:01 p.m.)
>> 
>> 
>> Review request for mesos and Jie Yu.
>> 
>> 
>> Repository: mesos
>> 
>> 
>> Description
>> -------
>> 
>> We currently dont handle special files like device files in rmdir. This change
>> adds FS_DEFAULT as one of the cases where we try to unlink a file.
>> 
>> Reference: http://man7.org/linux/man-pages/man3/fts.3.html
>> 
>> 
>> Diffs
>> -----
>> 
>>  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp bc420c9c10d93ddd619a9eb2c5f4db67f31d722f

>> 
>> Diff: https://reviews.apache.org/r/44230/diff/
>> 
>> 
>> Testing
>> -------
>> 
>> make check.
>> 
>> 
>> Thanks,
>> 
>> Jojy Varghese
>> 
>> 
> 


Mime
View raw message