mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Timothy Chen <tnac...@apache.org>
Subject Re: Review Request 45557: Clean up the health check launcher code in docker executor.
Date Thu, 31 Mar 2016 22:31:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45557/#review126480
-----------------------------------------------------------


Ship it!




Ship It!

- Timothy Chen


On March 31, 2016, 6:52 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45557/
> -----------------------------------------------------------
> 
> (Updated March 31, 2016, 6:52 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change cleans up the code a bit making it easier to read:
> 
> - Bail out early wherever possible to reduce nestedness of code
> making it easier to read.
> - Minor cleanups around merging conditions together wherever
> possible.
> 
> 
> Diffs
> -----
> 
>   src/docker/executor.cpp afc769d0887e3842106e4c350e94c95c8ffc085e 
> 
> Diff: https://reviews.apache.org/r/45557/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message