mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 45553: Minor cleanups in validation logic for operator endpoints.
Date Thu, 31 Mar 2016 21:03:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45553/#review126445
-----------------------------------------------------------



Patch looks great!

Reviews applied: [45553]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1
MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 31, 2016, 5:53 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45553/
> -----------------------------------------------------------
> 
> (Updated March 31, 2016, 5:53 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This trivial patch cleans up the following things:
> - Style in-consistencies where we used to take the hashmap
> as constant reference in other places but not in `teardown`
> call handler.
> - Avoid lookups twice in the hash map but save it in an
> `Option` variable. This is more consistent with the code
> at other places.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 03d4ebabfba1bf711fc0897801a989ac3c72f9f1 
> 
> Diff: https://reviews.apache.org/r/45553/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message