mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kapil Arya <ka...@mesosphere.io>
Subject Re: Review Request 44288: Changed MasterDetector/Contender namespace.
Date Thu, 31 Mar 2016 17:26:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44288/#review125919
-----------------------------------------------------------




include/mesos/v1/scheduler.hpp (lines 31 - 33)
<https://reviews.apache.org/r/44288/#comment188824>

    Can we keep the fwd declaration and remove the #include?



src/cli/resolve.cpp (lines 35 - 36)
<https://reviews.apache.org/r/44288/#comment188829>

    Can we just do `using mesos::master::detector::MasterDetector;` instead (like we do for
local.cpp below)?



src/master/contender.cpp (line 25)
<https://reviews.apache.org/r/44288/#comment188835>

    This needs to be moved above process headers.



src/master/contender.cpp (line 45)
<https://reviews.apache.org/r/44288/#comment188833>

    Looks like we can get rid of this using stmt. We don't seem to be using stuff from `internal`
namespace anyways (except at the bottom with an explicit declaration).



src/master/detector.cpp (line 33)
<https://reviews.apache.org/r/44288/#comment188837>

    Move above process headers.



src/master/detector.cpp (line 281)
<https://reviews.apache.org/r/44288/#comment188839>

    drop `mesos::` for consistency?



src/master/detector.cpp (line 305)
<https://reviews.apache.org/r/44288/#comment188840>

    ditto



src/master/detector.cpp (line 440)
<https://reviews.apache.org/r/44288/#comment188844>

    Please align it with the paren.
    
    Also drop `mesos::`



src/master/detector.cpp (line 453)
<https://reviews.apache.org/r/44288/#comment188845>

    same as above.



src/slave/main.cpp (line 263)
<https://reviews.apache.org/r/44288/#comment188848>

    Can we revert this since it's not directly related to review chain?



src/tests/authentication_tests.cpp (lines 38 - 39)
<https://reviews.apache.org/r/44288/#comment188849>

    Alphabetize



src/tests/cluster.cpp (lines 55 - 56)
<https://reviews.apache.org/r/44288/#comment188850>

    Please move the `using` stmts below #includes.
    
    Also, you might want to consider using:
    ```
        using mesos::master::contender::StandAlonContender;
        ...
    ```
    
    instead of doing the full namespace thing here.



src/tests/cluster.cpp (line 58)
<https://reviews.apache.org/r/44288/#comment188851>

    This is redundant with the above `using namespace` stmts, right?



src/tests/credentials_tests.cpp (line 38)
<https://reviews.apache.org/r/44288/#comment188852>

    Add a new line before this one.



src/tests/fault_tolerance_tests.cpp (lines 64 - 65)
<https://reviews.apache.org/r/44288/#comment188853>

    Alphabetize pls.



src/tests/master_allocator_tests.cpp (lines 59 - 60)
<https://reviews.apache.org/r/44288/#comment188854>

    alphabetize pls.



src/tests/master_authorization_tests.cpp (lines 52 - 53)
<https://reviews.apache.org/r/44288/#comment188855>

    ditto.



src/tests/master_contender_detector_tests.cpp (line 65)
<https://reviews.apache.org/r/44288/#comment188875>

    Move in front of MasterContender decl.



src/tests/master_contender_detector_tests.cpp (line 70)
<https://reviews.apache.org/r/44288/#comment188876>

    same as above.



src/tests/master_tests.cpp (lines 82 - 83)
<https://reviews.apache.org/r/44288/#comment188877>

    Alphabetize



src/tests/oversubscription_tests.cpp (lines 61 - 62)
<https://reviews.apache.org/r/44288/#comment189281>

    Alphabetize pls



src/tests/partition_tests.cpp (lines 50 - 51)
<https://reviews.apache.org/r/44288/#comment189282>

    ditto.



src/tests/persistent_volume_endpoints_tests.cpp (lines 49 - 53)
<https://reviews.apache.org/r/44288/#comment189283>

    alphabetize.



src/tests/persistent_volume_tests.cpp (lines 58 - 59)
<https://reviews.apache.org/r/44288/#comment189284>

    same



src/tests/reconciliation_tests.cpp (lines 51 - 52)
<https://reviews.apache.org/r/44288/#comment189285>

    Same



src/tests/reservation_tests.cpp (lines 56 - 57)
<https://reviews.apache.org/r/44288/#comment189286>

    same



src/tests/scheduler_event_call_tests.cpp (lines 45 - 46)
<https://reviews.apache.org/r/44288/#comment189287>

    Alphabetize



src/tests/scheduler_tests.cpp (line 78)
<https://reviews.apache.org/r/44288/#comment189288>

    this should come together with MasterDetector above.



src/tests/slave_recovery_tests.cpp (lines 78 - 79)
<https://reviews.apache.org/r/44288/#comment189289>

    Alphabetize.



src/tests/slave_tests.cpp (lines 71 - 72)
<https://reviews.apache.org/r/44288/#comment189290>

    ditto


- Kapil Arya


On March 23, 2016, 7:04 p.m., Anurag Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44288/
> -----------------------------------------------------------
> 
> (Updated March 23, 2016, 7:04 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Kapil Arya.
> 
> 
> Bugs: MESOS-4610
>     https://issues.apache.org/jira/browse/MESOS-4610
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Also modified users of MasterContender and MasterDetector to use this
> namespace.
> 
> 
> Diffs
> -----
> 
>   include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54 
>   include/mesos/v1/scheduler.hpp 765935e97b6c1686ab464a5cf1cf2dfd816f51f1 
>   src/cli/resolve.cpp 257e29034abf32491511f9a4e476b6859714829d 
>   src/local/local.cpp f8599e7378e9a0065bbd01ad8f23f11debb30c91 
>   src/master/contender.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 
>   src/master/detector.cpp 9274435802d6292b183be48f42b43999476e016e 
>   src/master/main.cpp 61210d9f275d4073967c3468179307cf09e88551 
>   src/master/master.hpp 124d43931a5c8a00ee0aaa604feb1761795209f2 
>   src/master/master.cpp e6290ea686ccf17813d6faeaf2f2012f79cf3b7f 
>   src/sched/sched.cpp 525255eec808c3fe5c0e38b3d1a2086bbd4eb171 
>   src/scheduler/scheduler.cpp 6a834473ef35540eedac7e211b5204ab5f4eb7b2 
>   src/slave/main.cpp 33a1af84aeb079224b15e92caf97bcf081ea4646 
>   src/slave/slave.hpp 7520cc356e2b1b7f5fff15f33071a46a7b05e762 
>   src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 
>   src/tests/authentication_tests.cpp 8143cd7a22bbdbcd0fc613cb44eae8b55fd458e7 
>   src/tests/cluster.hpp 06424dd741aed2261a926429bb0fc7dea141c11b 
>   src/tests/cluster.cpp 22167da70a855a39fd9c3ca980304372c70bd8d3 
>   src/tests/command_executor_tests.cpp 970cdc39f4f2b0377d36acf2465d377d2a6e1d05 
>   src/tests/container_logger_tests.cpp 71101c31cee6a400b89cf285cf0a105d2d1534a8 
>   src/tests/containerizer/docker_containerizer_tests.cpp f6fce7df82417e029fadf805d6e0b793f396aa69

>   src/tests/containerizer/external_containerizer_test.cpp 5e2116355418f5a0716cfd1573bab48ba75df596

>   src/tests/containerizer/filesystem_isolator_tests.cpp b3bd5a03266150a0cd83c966d646a32c419bf512

>   src/tests/containerizer/isolator_tests.cpp 6a2e25b967742c034364d19372f06aa9f9cdf828

>   src/tests/containerizer/memory_pressure_tests.cpp be6c3a118b528c39c534da423c15e9dcbb970dbc

>   src/tests/containerizer/port_mapping_tests.cpp de4b6f99f3a994bcedafa801eed9c4a7b79bac23

>   src/tests/containerizer/provisioner_docker_tests.cpp e4b30b9e51cd1191bfa9d9cf68a274814fdc4873

>   src/tests/containerizer/runtime_isolator_tests.cpp 9f3b0b08da7cebba722062a9932fae1b5f825efb

>   src/tests/credentials_tests.cpp b61ba2ea5df8957f12659de219f6a57cf30d987a 
>   src/tests/disk_quota_tests.cpp 7f5e32f3239db3adf6e4cec2df15ccf89b4f13f4 
>   src/tests/exception_tests.cpp a50ccf1255dee59fdbc6fb1539bd1f6429458fb4 
>   src/tests/executor_http_api_tests.cpp ff7b672e03185fca8b408b8805223a314fa3e483 
>   src/tests/fault_tolerance_tests.cpp f99413f56e96a796d3d45decad1f049e6a238789 
>   src/tests/fetcher_cache_tests.cpp 645dae208cb2b0aa2d2181d96eb1fd8893975430 
>   src/tests/gc_tests.cpp 42059b2d6544f360cdc9230fe6ed33a11a15bc50 
>   src/tests/health_check_tests.cpp d32164aeb1eb439bd062afa28614dd919e24f06b 
>   src/tests/hook_tests.cpp 595991deab38c34e918601e85d250dc995d0f34c 
>   src/tests/http_fault_tolerance_tests.cpp c06e07daf6d6519c10489310cd4275ae94f302c6 
>   src/tests/master_allocator_tests.cpp b41ba2bda4d680f6fc42f525719973d56c11fe31 
>   src/tests/master_authorization_tests.cpp 8b9b8991fbb8c5a5beb69416a9c4a4ef3525942d 
>   src/tests/master_contender_detector_tests.cpp bbce379e5a0a0ca608579d0ab2b10970e9cd5ef1

>   src/tests/master_maintenance_tests.cpp b42a81fc2e0982e8fca669bffb798c0acda684fc 
>   src/tests/master_quota_tests.cpp c2b46d23002481e63ff162e8628f9b974e3e8ef9 
>   src/tests/master_slave_reconciliation_tests.cpp 988f1d46580ab5a707fe801824e24f94d4f50da7

>   src/tests/master_tests.cpp d34ba0bdd71efd261850d8c205c16cecb701ac7c 
>   src/tests/master_validation_tests.cpp 8d0070a1b8e8dcc7fe6360f8c6c6182ba9edef7d 
>   src/tests/mesos.hpp aaef158e5784ce077ef60996ebbeb77b356b7c57 
>   src/tests/mesos.cpp 90aef6bfe619dc0acdb4ccba6a7180482dd13ce5 
>   src/tests/metrics_tests.cpp 51b4515369b5a72cd9613bb87e7b9df9e1118e83 
>   src/tests/monitor_tests.cpp 5dcb2481ff2f1a7caf54036bc3e60c78feb982b1 
>   src/tests/oversubscription_tests.cpp ba036810758d99a6fb0034c5e2bc7829e2343a44 
>   src/tests/partition_tests.cpp 349adbf67686e6044a2e6a4b673043ad74fce44e 
>   src/tests/persistent_volume_endpoints_tests.cpp d04063090e7f45b4c047a4e037eed1de79cd6958

>   src/tests/persistent_volume_tests.cpp 26fff19daa8b175fdcc06fd9467224d5920a1967 
>   src/tests/reconciliation_tests.cpp 5f541f5fe004ede943a1b022daab92f01d1f4853 
>   src/tests/registrar_zookeeper_tests.cpp 45b687cf96438e2ea8cc94ab2147e2538763e702 
>   src/tests/reservation_endpoints_tests.cpp 028e28c68e8a438d310df04fea0a7e54a6d642a3

>   src/tests/reservation_tests.cpp a9261bdf48c0af933e7fc303b7af356a60b49506 
>   src/tests/resource_offers_tests.cpp 1cf292ee7931207596f8f06677386bef5965ef15 
>   src/tests/role_tests.cpp 20ccca3ecdc53c65abd61190ef9f867c8e860578 
>   src/tests/scheduler_driver_tests.cpp 824aa96106808f7e259fb755257034c89c997287 
>   src/tests/scheduler_event_call_tests.cpp 00e99777ba0294c9c12ac86594987afbd9388b51 
>   src/tests/scheduler_http_api_tests.cpp b65790a9aad0ca68c6a93dd1d872442b906598fd 
>   src/tests/scheduler_tests.cpp 917058f4dcf32ddaaeda8a3ff21898571f4829dd 
>   src/tests/slave_recovery_tests.cpp 0d59a06f8e32f3d88f6c3a222bc6756a889a142e 
>   src/tests/slave_tests.cpp ea1d776077bf638885db8421194aa4427c772169 
>   src/tests/status_update_manager_tests.cpp 801767ba6b4a08a4f653a7735bf3a581a0f8f95f

> 
> Diff: https://reviews.apache.org/r/44288/diff/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/44670/.
> 
> 
> Thanks,
> 
> Anurag Singh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message