mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Deshi Xiao <xia...@gmail.com>
Subject Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.
Date Thu, 31 Mar 2016 03:41:35 GMT


> On 三月 31, 2016, 2:03 a.m., Jie Yu wrote:
> > This is a high level question: I am now sure if adding attributes is safe or not.
For instance, my framework has the following rule: only schedule tasks to agents that do not
have attribute "not_safe". Now, say agent A is initially without that attribute. My framework
lands several tasks on that agent. Later, when agent restarts, the operator adds the new attribute
"not_safe". Suddently, i have tasks running on unsafe boxes. oops.

I think so, this is very common case. it need more detail discussion with team.


- Deshi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45474/#review126242
-----------------------------------------------------------


On 三月 30, 2016, 8:13 a.m., Deshi Xiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45474/
> -----------------------------------------------------------
> 
> (Updated 三月 30, 2016, 8:13 a.m.)
> 
> 
> Review request for mesos, Adam B, Greg Mann, haosdent huang, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-1739
>     https://issues.apache.org/jira/browse/MESOS-1739
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Phase 1
> Make SlaveInfo mutable throughout the stack, and allow for expansion of resources and
attributes only (Which allows testing to make sure it propagates to the allocator, shows up
in offers, etc). Ensure there is unified checking for incompatibilities in both the slave
and master (the slave should validate the config, the master should validate that all operations
the slave takes are legal).
> 
> it derived from another PR(https://reviews.apache.org/r/25525/)
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp 1f1a31020096efa5db698e86ac74e61dfdb4b94a 
> 
> Diff: https://reviews.apache.org/r/45474/diff/
> 
> 
> Testing
> -------
> 
> make check on localhost
> 
> 
> Thanks,
> 
> Deshi Xiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message