mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 45500: Fix Mesos-1104, linux/fs.hpp remove mesos::internal:: should be enough.
Date Thu, 31 Mar 2016 01:28:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45500/#review126233
-----------------------------------------------------------




src/linux/fs.hpp 
<https://reviews.apache.org/r/45500/#comment189149>

    ```
    grep -r 'mesos::internal::fs' .
    ./src/slave/containerizer/mesos/mount.cpp:    Try<Nothing> mount = mesos::internal::fs::mount(
    ./src/tests/containerizer/fs_tests.cpp:using mesos::internal::fs::MountTable;
    ./src/tests/containerizer/fs_tests.cpp:using mesos::internal::fs::FileSystemTable;
    ./src/tests/containerizer/fs_tests.cpp:using mesos::internal::fs::MountInfoTable;
    ./src/tests/containerizer/port_mapping_tests.cpp:      mesos::internal::fs::unmount(target,
MNT_DETACH);
    ```
    
    I think these places need to be updated as well.



src/linux/fs.hpp 
<https://reviews.apache.org/r/45500/#comment189150>

    And need remove 
    ```
    // TODO(benh): Move linux/fs.hpp out of 'mesos- namespace.
    using namespace mesos::internal;
    ```
    in `linux/fs.cpp` as well.


- haosdent huang


On March 30, 2016, 6:47 p.m., Deshi Xiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45500/
> -----------------------------------------------------------
> 
> (Updated March 30, 2016, 6:47 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Cong Wang.
> 
> 
> Bugs: MESOS-1104
>     https://issues.apache.org/jira/browse/MESOS-1104
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> other exists code under src/linux/, e.g. perf.hpp, ns.hpp
> I think remove mesos::internal:: should be enough.
> 
> 
> Diffs
> -----
> 
>   src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 
> 
> Diff: https://reviews.apache.org/r/45500/diff/
> 
> 
> Testing
> -------
> 
> make check on localhost(centos)
> 
> 
> Thanks,
> 
> Deshi Xiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message