mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 45480: Replace NULL with nullptr.
Date Wed, 30 Mar 2016 18:31:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45480/#review126168
-----------------------------------------------------------



Patch looks great!

Reviews applied: [45480]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1
MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 30, 2016, 11:07 a.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45480/
> -----------------------------------------------------------
> 
> (Updated March 30, 2016, 11:07 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3243
>     https://issues.apache.org/jira/browse/MESOS-3243
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> RUN: `run-clang-tidy.py src -fix -checks="-*,modernize-use-nullptr" -p build -fix`
> 
> 
> Diffs
> -----
> 
>   src/authentication/cram_md5/authenticatee.cpp 7d4994333428e5d8aa9ce6b85e0a7f42a0ddc4c8

>   src/authentication/cram_md5/auxprop.cpp d82d2d2f7793859772d89cc91bee09240624c613 
>   src/authorizer/local/authorizer.cpp 0f0d9276337858984f0b19a82ffca74ee84dc650 
>   src/examples/balloon_executor.cpp 399218478a596387814d123290eeeb33102fad7a 
>   src/examples/example_module_impl.cpp aeffdc0e95fa7badc8cfa09e2b57462e427fec55 
>   src/examples/load_generator_framework.cpp b22a09e1749d4b523addacad99858d7b6bde3403

>   src/examples/test_allocator_module.cpp 1255a4a22a9d1a5724bef78dfc4dee498ed50fff 
>   src/examples/test_anonymous_module.cpp dd291cff3b5d47337e371cd2c1082fd6716af3fc 
>   src/examples/test_authorizer_module.cpp 19ec7cd114562f74c660b83b39235127d25001ee 
>   src/examples/test_container_logger_module.cpp 76dd494fa4c32514ba14b1f4498b588ac9051b4d

>   src/examples/test_http_authenticator_module.cpp 8affdb60ae6336a2be5218c7bd04a4d5efeeb3f4

>   src/examples/test_isolator_module.cpp a4a2103b1e449837b95948c8b5c25e05c5d13860 
>   src/examples/test_qos_controller_module.cpp f382fc443fa0a4545ba78dc28016e4d0a0dd16b1

>   src/examples/test_resource_estimator_module.cpp 229b2931e9129c194850f04051060d33bfa06570

>   src/java/jni/convert.cpp f1a486d8d2f6d43efd89407c928734bd9715e591 
>   src/java/jni/org_apache_mesos_Log.cpp 140b950136417eed7cba363a89537ed2f33832ff 
>   src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 9a92ade5d54bd814353acb40170d7aa4d8fe4a77

>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp c723e2d7bce98e6ac5ab587ce8c42fa9ba8b47e4

>   src/java/jni/org_apache_mesos_state_AbstractState.cpp 4fd43ca31c6917e81ea1b331b8507ca42a2249cf

>   src/java/jni/org_apache_mesos_state_Variable.cpp 7a69b3d878e6eaa87bfaf56c0500e11efe4ac44d

>   src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 23a89c3e5c5309a8a9b45c168fb61b12d89db1ec

>   src/jvm/jvm.cpp 779f8b987e2673ca5ab924caf00eea09a0a79af5 
>   src/launcher/executor.cpp 4e9b4d9820f7c2f4cb1b3e16e2f4c8c13500693f 
>   src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 
>   src/local/local.cpp e777ea2938a23db8b407676a0f7e635e63d032fa 
>   src/log/leveldb.cpp ba2f62bc97e4a0eaa8a54824551686467db4b9e4 
>   src/log/log.cpp a37676068dae14b1adc61ef75e2742c16e7a6e42 
>   src/log/tool/benchmark.cpp 770c6d85fec76826ca8369b2afc721c07899e32f 
>   src/log/tool/initialize.cpp bd1e9ef1922ae972a5999b6e7412e08eac92c1ac 
>   src/log/tool/read.cpp b9e90e44c8cd7351767e523af338d8c662e0848c 
>   src/log/tool/replica.cpp 49415821a32960c78192b89f9a0f2067b9157a63 
>   src/master/contender.cpp 846f516edcc63affd05158e9e5235e6d97f67f15 
>   src/master/main.cpp 58561cffa440aaf1293e9ffe19b5685e6d2f1952 
>   src/master/validation.cpp 9c9e42283baa6e49d86af2ce7222131ce53ccaff 
>   src/slave/container_loggers/logrotate.cpp 7d36c052ff7a180b45ca265fb7ff4c6900d98d64

>   src/slave/qos_controllers/load.cpp dd44f9209ad283bfea95f16a8c1017e309757f23 
>   src/slave/resource_estimators/fixed.cpp c858a48bc137185d1e1e24a20f6b75b0dd7912ff 
>   src/state/leveldb.cpp f925a73856075f08c4af2af0fcaae8e81358667e 
>   src/tests/containerizer/memory_test_helper.cpp 92579a28336b3c15ba7fdbb4a9f769ac7182aeb6

>   src/tests/environment.cpp 7617e43587cb81104786d06f753f08565a6c2d0a 
>   src/tests/mesos.cpp 77d49cc65e08f040b0d2010cd083928e4ff8b7cd 
>   src/tests/registrar_tests.cpp 39caf9bb950c0b229a66becb039c7a830a18f6bc 
>   src/tests/state_tests.cpp 0b5a6abadc24d16aa0e5e5f2f4b0c9f524c399ec 
>   src/tests/zookeeper_test_server.cpp 0dc041fef8973d35114b9f76a6a4002853884670 
>   src/zookeeper/group.cpp ca5e99d09825bf5ace7ba59c95266c51e246974f 
>   src/zookeeper/zookeeper.cpp 02fa158a37ddaf045bdf6403c134d03a02c74833 
> 
> Diff: https://reviews.apache.org/r/45480/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message