mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 45471: Fix a test case bug due to upgrade http-parser to 2.6.1.
Date Wed, 30 Mar 2016 18:18:26 GMT


> On March 30, 2016, 6:10 p.m., Greg Mann wrote:
> > This could break existing clients which include extra whitespace, though it does
seem that RFC-7230 specifically prohibits whitespace in that location. I wonder if a deprecation
cycle is advisable for this change?
> > 
> > Also, it's not immediately clear to me: are we using http-parser in "strict" mode?

Good point. Though I would be surprised if typical clients use colons after header names.
IIIUC (zhiwei can correct me if i'm wrong) 2.6.1 disallowed spaces before colon irrespective
of strict mode (which was a bug). I think they fixed the behavior in 2.6.2 so that it rejects
spaces iff the mode is strict. If that's the case, we should probably just upgrade to 2.6.2
instead of 2.6.1?


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45471/#review126160
-----------------------------------------------------------


On March 30, 2016, 5:35 a.m., Zhiwei Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45471/
> -----------------------------------------------------------
> 
> (Updated March 30, 2016, 5:35 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Vinod Kone.
> 
> 
> Bugs: MESOS-5063
>     https://issues.apache.org/jira/browse/MESOS-5063
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix a test case bug due to upgrade http-parser to 2.6.1.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/ssl_tests.cpp 53a0ed03226030104af43a45c6ccfbfc0f4b7e9f

> 
> Diff: https://reviews.apache.org/r/45471/diff/
> 
> 
> Testing
> -------
> 
> ../configure --enable-libevent --enable-ssl
> 
> sudo make dist check
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message