mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 45471: Fix a test case bug due to upgrade http-parser to 2.6.1.
Date Wed, 30 Mar 2016 18:10:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45471/#review126160
-----------------------------------------------------------



This could break existing clients which include extra whitespace, though it does seem that
RFC-7230 specifically prohibits whitespace in that location. I wonder if a deprecation cycle
is advisable for this change?

Also, it's not immediately clear to me: are we using http-parser in "strict" mode?

- Greg Mann


On March 30, 2016, 5:35 a.m., Zhiwei Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45471/
> -----------------------------------------------------------
> 
> (Updated March 30, 2016, 5:35 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Vinod Kone.
> 
> 
> Bugs: MESOS-5063
>     https://issues.apache.org/jira/browse/MESOS-5063
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix a test case bug due to upgrade http-parser to 2.6.1.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/ssl_tests.cpp 53a0ed03226030104af43a45c6ccfbfc0f4b7e9f

> 
> Diff: https://reviews.apache.org/r/45471/diff/
> 
> 
> Testing
> -------
> 
> ../configure --enable-libevent --enable-ssl
> 
> sudo make dist check
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message