mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 45474: MESOS-1739: Allow slave reconfiguration on restart, Phase 1.
Date Wed, 30 Mar 2016 06:52:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45474/#review126042
-----------------------------------------------------------



I think the better place to put this test case is `slave_recovery_tests.cpp`.


src/tests/slave_tests.cpp (line 3488)
<https://reviews.apache.org/r/45474/#comment188950>

    I think could remove all `this->`.



src/tests/slave_tests.cpp (line 3543)
<https://reviews.apache.org/r/45474/#comment188952>

    I think could remove `slave->reset();` here.


- haosdent huang


On March 30, 2016, 6:35 a.m., Deshi Xiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45474/
> -----------------------------------------------------------
> 
> (Updated March 30, 2016, 6:35 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-1739
>     https://issues.apache.org/jira/browse/MESOS-1739
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Phase 1
> Make SlaveInfo mutable throughout the stack, and allow for expansion of resources and
attributes only (Which allows testing to make sure it propagates to the allocator, shows up
in offers, etc). Ensure there is unified checking for incompatibilities in both the slave
and master (the slave should validate the config, the master should validate that all operations
the slave takes are legal).
> 
> it derived from another PR(https://reviews.apache.org/r/25525/)
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp 1f1a31020096efa5db698e86ac74e61dfdb4b94a 
> 
> Diff: https://reviews.apache.org/r/45474/diff/
> 
> 
> Testing
> -------
> 
> make check on localhost
> 
> 
> Thanks,
> 
> Deshi Xiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message