mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 44979: Filled in the guts of the Nvidia GPU isolator.
Date Tue, 29 Mar 2016 19:06:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44979/#review125936
-----------------------------------------------------------



This review has been superceded by: https://reviews.apache.org/r/45439

- Kevin Klues


On March 17, 2016, 9:29 p.m., Rob Todd wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44979/
> -----------------------------------------------------------
> 
> (Updated March 17, 2016, 9:29 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Kevin Klues, and Vikrama Ditya.
> 
> 
> Bugs: Mesos-4625
>     https://issues.apache.org/jira/browse/Mesos-4625
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Filled in the guts of the Nvidia GPU isolator.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.hpp PRE-CREATION

>   src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.cpp PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/44979/diff/
> 
> 
> Testing
> -------
> 
> This was the initial work to fill in the constructor/destructor, update(), create(),
and cleanup() methods pre-stylistic review by Kevin.  Will push the stylistic review changes
as a separate diff such that they can be explicitly seen by any potential contributor.
> 
> 
> Thanks,
> 
> Rob Todd
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message