mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Mahler <benjamin.mah...@gmail.com>
Subject Re: Review Request 44974: Added device support in cgroups abstraction.
Date Tue, 29 Mar 2016 02:01:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44974/#review125782
-----------------------------------------------------------


Fix it, then Ship it!




Thanks! Kevin and I went over this and made some adjustments to the comments and error formatting.
Will commit shortly.


src/linux/cgroups.hpp (line 625)
<https://reviews.apache.org/r/44974/#comment188652>

    s/subsytem/subsystem/ and end with a period here



src/linux/cgroups.hpp (lines 628 - 629)
<https://reviews.apache.org/r/44974/#comment188655>

    How about s/ListEntry/Entry/ ? I was a bit confused about whether "whitelist" in this
context meant that this isn't used for the "deny" file, for example.



src/linux/cgroups.hpp (lines 634 - 664)
<https://reviews.apache.org/r/44974/#comment188662>

    I'm not sure if we need some of these comments, for example I can tell pretty easily from
'Access' that it represents the access permissions and it is part of a whitelist entry because
it is contained within the ListEntry class. Ditto for selector.


- Ben Mahler


On March 21, 2016, 6:06 a.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44974/
> -----------------------------------------------------------
> 
> (Updated March 21, 2016, 6:06 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Felix Abecassis, Kevin Klues, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3368
>     https://issues.apache.org/jira/browse/MESOS-3368
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> There are some helper methods added to support device cgroups in
> cgroups abstraction to aid isolators controlling access to devices.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.hpp 51ccefd1fd2d0989b9bd31342d3d1e3701f88ed2 
>   src/linux/cgroups.cpp df18ed46a2a96871f67c7eb4233c3b4c27b7aa1c 
> 
> Diff: https://reviews.apache.org/r/44974/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message