mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 45121: Implemented deletion for persistent volumes.
Date Sat, 26 Mar 2016 00:37:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45121/#review125492
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/slave.cpp (line 2333)
<https://reviews.apache.org/r/45121/#comment188289>

    insert a space before 'at'



src/slave/slave.cpp (lines 2344 - 2347)
<https://reviews.apache.org/r/45121/#comment188292>

    This is not a problem for PATH type disk. But it's definitely a problem for MOUNT type
disk since it'll be offered to the framework, and the framework might create a new volume
on top of that. We might want to do a cleanup when we create a volume from MOUNT type disk.
Can you make sure the TODO captures that as well?



src/slave/slave.cpp (line 2373)
<https://reviews.apache.org/r/45121/#comment188293>

    I would suggest we don't use CHECK here. We can just LOG(ERROR) if the deletion fails.
Given the TODO above, we could leak disk space anyway.


- Jie Yu


On March 21, 2016, 6:44 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45121/
> -----------------------------------------------------------
> 
> (Updated March 21, 2016, 6:44 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2408
>     https://issues.apache.org/jira/browse/MESOS-2408
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Prior to this commit, destroying a persistent volume would remove
> the Mesos-level metadata about the volume, but wouldn't destroy
> any of the volume's filesystem content. We now remove the volume
> from the slave's filesystem, essentially via "rm -r".
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 
> 
> Diff: https://reviews.apache.org/r/45121/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message