mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 45120: Extended `os::rmdir` in stout to support preserving the root directory.
Date Sat, 26 Mar 2016 00:25:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45120/
-----------------------------------------------------------

(Updated March 26, 2016, 12:25 a.m.)


Review request for mesos, Jie Yu and Joris Van Remoortere.


Changes
-------

Address review comments, rebase.


Bugs: MESOS-2408
    https://issues.apache.org/jira/browse/MESOS-2408


Repository: mesos


Description
-------

This allows `os::rmdir("/x")` to optionally remove all the child
files and directories of the root directory "/x", but preserve "/x"
itself.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp 44a59b830f4a09c9a19d55d3e99154ca8e4d2593

  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp 4e3dd0ff8cbfe470b14c7cacbd861e7dc8384ba1

  3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp 5466991675778c59d8040946717b492cdb1f9b14


Diff: https://reviews.apache.org/r/45120/diff/


Testing
-------

make check


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message