mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Re: Review Request 44846: Deprecated the plain text credential format.
Date Thu, 24 Mar 2016 10:48:53 GMT


> On March 17, 2016, 6:21 p.m., Joerg Schad wrote:
> > src/master/flags.cpp, line 227
> > <https://reviews.apache.org/r/44846/diff/2/?file=1299753#file1299753line227>
> >
> >     We now mention deprecated twice here.
> >     The 'Note that' also seems to be out of sync with the configuration.md.

The whole sentence will be removed, as per Adam's comments below the deprecated format won't
be mentioned at all.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44846/#review124051
-----------------------------------------------------------


On March 15, 2016, 3:01 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44846/
> -----------------------------------------------------------
> 
> (Updated March 15, 2016, 3:01 p.m.)
> 
> 
> Review request for mesos, Adam B and Joerg Schad.
> 
> 
> Bugs: MESOS-2281
>     https://issues.apache.org/jira/browse/MESOS-2281
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Deprecated the plain text credential format.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 761238c48332bcce0bff6c411225fdb4176ddca6 
>   docs/authentication.md e7c0bf3ed331411f607e7622419f14853006a480 
>   docs/configuration.md 739d4ff9aeeb1ba70ce11033168d63d37b6ef56b 
>   docs/upgrades.md 83b839f7fb996385baaa6ef1081dc1116cd6e338 
>   src/credentials/credentials.hpp aad17c21bb0ce98907bbfa22b890b66130e081e4 
>   src/master/flags.cpp e6fea6421ea1a16b9cd78b0e42b830829b95ad61 
>   src/slave/flags.cpp 4d10818105627738e258116647ccada374e3d7b9 
> 
> Diff: https://reviews.apache.org/r/44846/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message