mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 45151: Updated FrameworkInfo::Capability::Type enum for upgradability.
Date Wed, 23 Mar 2016 23:24:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45151/#review125151
-----------------------------------------------------------



Patch looks great!

Reviews applied: [45151]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1
MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 23, 2016, 5:58 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45151/
> -----------------------------------------------------------
> 
> (Updated March 23, 2016, 5:58 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Vinod Kone.
> 
> 
> Bugs: MESOS-4997
>     https://issues.apache.org/jira/browse/MESOS-4997
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Per [MESOS-4977](https://issues.apache.org/jira/browse/MESOS-4977), having a required
enum field is problematic for supporting adding new enum values.
> 
> This updates FrameworkInfo::Capability to support the addition of new capabilities while
allowing old masters to deserialize the new messages.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto b965f5a6b1aff28feb2ab088c30ea927b9247403 
>   include/mesos/v1/mesos.proto d2ab6ed187ec0d0e5dbac92607b612bb55b1a682 
> 
> Diff: https://reviews.apache.org/r/45151/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> manually validated the upgrade / backwards compatibility of enum fields
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message