-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44622/#review124858
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/containerizer/mesos/isolators/network/cni/cni.hpp (line 30)
<https://reviews.apache.org/r/44622/#comment187555>
Let's not use this. Just use fully qualified name in the header.
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 41)
<https://reviews.apache.org/r/44622/#comment187556>
Let's do
```
namespace spec = mesos::internal::slave::cni::spec;
```
- Jie Yu
On March 22, 2016, 7:33 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44622/
> -----------------------------------------------------------
>
> (Updated March 22, 2016, 7:33 a.m.)
>
>
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
>
>
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Introduced a protobuf message "NetworkInfo".
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/network/cni/cni.hpp PRE-CREATION
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp PRE-CREATION
> src/slave/containerizer/mesos/isolators/network/cni/spec.hpp PRE-CREATION
> src/slave/containerizer/mesos/isolators/network/cni/spec.cpp PRE-CREATION
> src/slave/containerizer/mesos/isolators/network/cni/spec.proto PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44622/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Qian Zhang
>
>
|