mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <mazumdar.an...@gmail.com>
Subject Review Request 45166: Fixed flaky `MasterTest.SlavesEndpointTwoSlaves`.
Date Tue, 22 Mar 2016 17:29:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45166/
-----------------------------------------------------------

Review request for mesos, Alexander Rojas and Neil Conway.


Bugs: MESOS-4984
    https://issues.apache.org/jira/browse/MESOS-4984


Repository: mesos


Description
-------

We were not correctly waiting for the master to register the
slave before making a call to the `slaves` endpoint. This change
adds a pause/settle to ensure that. Note that `FUTURE_PROTOBUF`
just gurrantees that the method has dispatched but does not ensure
that it has completed.


Diffs
-----

  src/tests/master_tests.cpp d34ba0bdd71efd261850d8c205c16cecb701ac7c 

Diff: https://reviews.apache.org/r/45166/diff/


Testing
-------

Ran it in a loop. Previously used to fail quite often.


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message