mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fan du <fan...@intel.com>
Subject Re: Review Request 45097: Update metrics for SUBSCRIBE call for both PID/HTTP frameworks.
Date Tue, 22 Mar 2016 06:42:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45097/
-----------------------------------------------------------

(Updated 三月 22, 2016, 6:42 a.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Changes
-------

Fix coredump reported by test roboot


Bugs: MESOS-4981
    https://issues.apache.org/jira/browse/MESOS-4981


Repository: mesos


Description
-------

This change will cover three cases:
1. Directly call {re}registerFramework
2. Through HTTP call
3. Through MesosSchedulerDriver

And don't overlap 'master/messages_register_framework' with
'master/messages_reregister_framework'.


Diffs (updated)
-----

  src/master/master.cpp e6290ea686ccf17813d6faeaf2f2012f79cf3b7f 

Diff: https://reviews.apache.org/r/45097/diff/


Testing (updated)
-------

1. I can use 'docker-no-executor-framework' to reproduce/verify the issue.

"master/messages_register_framework": 1.0,
"master/messages_reregister_framework": 0.0,

2. Fix make check error by implementing 'minus' operation correctly for Counter.

make check GTEST_FILTER="AuthenticationTest*"
[----------] 21 tests from AuthenticationTest (7019 ms total)

[----------] Global test environment tear-down
[==========] 21 tests from 1 test case ran. (7140 ms total)
[  PASSED  ] 21 tests.


Thanks,

fan du


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message