mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Mahler <benjamin.mah...@gmail.com>
Subject Re: Review Request 45134: Skip FetcherTest zip tests when `unzip` is uninstalled.
Date Tue, 22 Mar 2016 02:09:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45134/#review124710
-----------------------------------------------------------




src/tests/fetcher_tests.cpp (lines 647 - 651)
<https://reviews.apache.org/r/45134/#comment187343>

    Take a look at environment.cpp for our approach to test filtering, the "curl" filter is
a good example:
    
    https://github.com/apache/mesos/blob/0.28.0/src/tests/environment.cpp#L229-L251


- Ben Mahler


On March 22, 2016, 12:14 a.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45134/
> -----------------------------------------------------------
> 
> (Updated March 22, 2016, 12:14 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4993
>     https://issues.apache.org/jira/browse/MESOS-4993
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Skip FetcherTest zip tests when `unzip` is uninstalled.
> 
> 
> Diffs
> -----
> 
>   src/tests/fetcher_tests.cpp 375e690ead4f954a66a6efc2f2daa7fb1f1a024d 
> 
> Diff: https://reviews.apache.org/r/45134/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message