mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.
Date Mon, 21 Mar 2016 16:41:14 GMT


> On March 19, 2016, 10:10 p.m., Jie Yu wrote:
> > src/linux/xfs.cpp, line 17
> > <https://reviews.apache.org/r/44946/diff/3/?file=1304831#file1304831line17>
> >
> >     Move this after below stout headers.

The Mesos C++ style guide says that this should come first.


> On March 19, 2016, 10:10 p.m., Jie Yu wrote:
> > src/linux/xfs.cpp, line 53
> > <https://reviews.apache.org/r/44946/diff/3/?file=1304831#file1304831line53>
> >
> >     Instead of relying on parameter, can we use os::stat::isdir here?

``isdir`` always follows symlinks. From the caller of this we always make sure what kind of
inode we have so we don't need to ``stat(2)`` again and potentially get it wrong.


> On March 19, 2016, 10:10 p.m., Jie Yu wrote:
> > src/linux/xfs.cpp, line 187
> > <https://reviews.apache.org/r/44946/diff/3/?file=1304831#file1304831line187>
> >
> >     This interface looks weird. I understand that project quota is set on the device
level. Can we make it explicit? and expose another public method to get device by path?

This is not a general-purpose interface; it's just here for the XFS isolator. If we require
a device path here, then we just foist that work off onto the caller. I think that it is simpler
to hide the device requirement from that level and just do it implicitly (at least until we
can show there's a performance win to allowing the caller to cache it).


> On March 19, 2016, 10:10 p.m., Jie Yu wrote:
> > src/linux/xfs.cpp, line 195
> > <https://reviews.apache.org/r/44946/diff/3/?file=1304831#file1304831line195>
> >
> >     is block size always 512 bytes in xfs? If not, worth adding a TODO.

Basic blocks not related to the underlying filesystem block size, they are just a 512 byte
unit used in the quota API.


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44946/#review124427
-----------------------------------------------------------


On March 21, 2016, 2 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44946/
> -----------------------------------------------------------
> 
> (Updated March 21, 2016, 2 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4828
>     https://issues.apache.org/jira/browse/MESOS-4828
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add utility functions to manipulate XFS project quotas.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf 
>   src/linux/xfs.hpp PRE-CREATION 
>   src/linux/xfs.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44946/diff/
> 
> 
> Testing
> -------
> 
> Make check. Manual verification. Tests in subsequent patches.
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message