-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44672/#review124567
-----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp (line 171)
<https://reviews.apache.org/r/44672/#comment187187>
What if `reference.has_registry() == true`?
For instance, a user can specify:
`index.docker.io/busybox`
- Jie Yu
On March 21, 2016, 6:44 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44672/
> -----------------------------------------------------------
>
> (Updated March 21, 2016, 6:44 a.m.)
>
>
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, Shuai Lin, and Timothy
Chen.
>
>
> Bugs: MESOS-4877
> https://issues.apache.org/jira/browse/MESOS-4877
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added normalize method to registry puller.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 6d637ed14f35feb554c8fcc63a7a7e046aaca574
>
> Diff: https://reviews.apache.org/r/44672/diff/
>
>
> Testing
> -------
>
> make check
>
> sudo ./bin/mesos-test.sh --gtest_filter="*ProvisionerDockerRegistryPullerTest*"
>
>
> Thanks,
>
> Gilbert Song
>
>
|