mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam B <a...@mesosphere.io>
Subject Re: Review Request 45036: Added authentication information to agent endpoints.
Date Mon, 21 Mar 2016 10:28:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45036/#review124525
-----------------------------------------------------------


Fix it, then Ship it!




Agent endpoints help looks good, but it makes me think we messed up on Master /flags..


src/slave/http.cpp (lines 351 - 354)
<https://reviews.apache.org/r/45036/#comment187126>

    Looks like `Master::Http::FLAGS_HELP()` is incorrectly using AUTHENTICATION() as its DESCRIPTION
parameter.. Amirite?


- Adam B


On March 21, 2016, 3:22 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45036/
> -----------------------------------------------------------
> 
> (Updated March 21, 2016, 3:22 a.m.)
> 
> 
> Review request for mesos, Adam B and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Agent endpoint help now displays information whether authentication (if enabled) is required
in HELP.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp 4eb1fafdfa72094511b0b2684a3c2705bd8c7c5e 
> 
> Diff: https://reviews.apache.org/r/45036/diff/
> 
> 
> Testing
> -------
> 
> Checked agent help endpoint.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message