mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Browning <>
Subject Re: Review Request 45046: Created URI.filename to name fetched files in sandbox where appropriate.
Date Mon, 21 Mar 2016 03:14:23 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated March 21, 2016, 3:14 a.m.)

Review request for mesos, Vinod Kone and Zhitao Li.


Changed invocations of mktmp and mkdtmp in tests to use XXXXXX naming pattern.

Bugs: MESOS-4735

Repository: mesos


Created URI.filename to name fetched files in sandbox where appropriate.

Diffs (updated)

  CHANGELOG 761238c48332bcce0bff6c411225fdb4176ddca6 
  docs/ f70939d8410516c9387a8cba86b5b75539a5fe9a 
  include/mesos/mesos.proto deb9c0910a27afd67276f54b3f666a878212727b 
  include/mesos/v1/mesos.proto a981e750c24cfc48177bbc9ca56f0c3ecfae1a1b 
  src/launcher/fetcher.cpp f85b118fb19cf9d4563f89847a783be35067e815 
  src/slave/containerizer/fetcher.hpp bbdce88da6e41dbb88681bc9d604b00923033b3d 
  src/slave/containerizer/fetcher.cpp 33dfcade6beb53a5a6dbc41a8f3380f5cb30a161 
  src/tests/fetcher_cache_tests.cpp 645dae208cb2b0aa2d2181d96eb1fd8893975430 
  src/tests/fetcher_tests.cpp fb47706eb90ae5808bafe13c681d609a808b0c8e 



There are two paths by which a file gets fetched to the executor sandbox: the without-cache
path, where the fetcher downloads the file directly from the specified URI, and the with-cache
path, where it copies it from the cache. In both cases, we verify that the file is saved to
the sandbox directory with the name specified by the "filename" field in the CommandInfo.URI


Michael Browning

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message