mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.
Date Sat, 19 Mar 2016 22:10:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44946/#review124427
-----------------------------------------------------------




src/linux/xfs.cpp (line 17)
<https://reviews.apache.org/r/44946/#comment186978>

    Move this after below stout headers.



src/linux/xfs.cpp (line 49)
<https://reviews.apache.org/r/44946/#comment186979>

    Kill one line here.



src/linux/xfs.cpp (line 53)
<https://reviews.apache.org/r/44946/#comment186985>

    Instead of relying on parameter, can we use os::stat::isdir here?



src/linux/xfs.cpp (line 79)
<https://reviews.apache.org/r/44946/#comment186980>

    Let's try to be consistent here. Either use "xfsctl" or "::xfsctl", but consistently.



src/linux/xfs.cpp (line 118)
<https://reviews.apache.org/r/44946/#comment186981>

    isError



src/linux/xfs.cpp (line 149)
<https://reviews.apache.org/r/44946/#comment186986>

    A nits: can you move all helpers above public functions.



src/linux/xfs.cpp (line 185)
<https://reviews.apache.org/r/44946/#comment186983>

    2 lines apart.



src/linux/xfs.cpp (line 187)
<https://reviews.apache.org/r/44946/#comment186989>

    This interface looks weird. I understand that project quota is set on the device level.
Can we make it explicit? and expose another public method to get device by path?



src/linux/xfs.cpp (line 191)
<https://reviews.apache.org/r/44946/#comment186988>

    Can you return Error instead of CHECK here?



src/linux/xfs.cpp (line 195)
<https://reviews.apache.org/r/44946/#comment186987>

    is block size always 512 bytes in xfs? If not, worth adding a TODO.



src/linux/xfs.cpp (line 196)
<https://reviews.apache.org/r/44946/#comment186984>

    indentation.


- Jie Yu


On March 18, 2016, 3:46 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44946/
> -----------------------------------------------------------
> 
> (Updated March 18, 2016, 3:46 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4828
>     https://issues.apache.org/jira/browse/MESOS-4828
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add utility functions to manipulate XFS project quotas.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf 
>   src/linux/xfs.hpp PRE-CREATION 
>   src/linux/xfs.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44946/diff/
> 
> 
> Testing
> -------
> 
> Make check. Manual verification. Tests in subsequent patches.
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message