mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Browning <mrbrown...@uber.com>
Subject Re: Review Request 45046: Created URI.filename to name fetched files in sandbox where appropriate.
Date Sat, 19 Mar 2016 21:52:14 GMT


> On March 19, 2016, 10:07 a.m., Guangya Liu wrote:
> > src/tests/fetcher_cache_tests.cpp, lines 690-691
> > <https://reviews.apache.org/r/45046/diff/2/?file=1307068#file1307068line690>
> >
> >     blank line here

I'd like to push back against this one -- I think adding a line break here (I assume because
of the comment block?) would suggest that the previous line is distinct in some way from the
rest of the paragraph, and that's not really the case. If anything, I would expect it between
the assignments and the following assertions, but I don't have a strong preference between
break/no break in that case.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45046/#review124393
-----------------------------------------------------------


On March 18, 2016, 11:30 p.m., Michael Browning wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45046/
> -----------------------------------------------------------
> 
> (Updated March 18, 2016, 11:30 p.m.)
> 
> 
> Review request for mesos, Vinod Kone and Zhitao Li.
> 
> 
> Bugs: MESOS-4735
>     https://issues.apache.org/jira/browse/MESOS-4735
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Created URI.filename to name fetched files in sandbox where appropriate.
> 
> 
> Diffs
> -----
> 
>   docs/fetcher.md f70939d8410516c9387a8cba86b5b75539a5fe9a 
>   include/mesos/mesos.proto deb9c0910a27afd67276f54b3f666a878212727b 
>   include/mesos/v1/mesos.proto a981e750c24cfc48177bbc9ca56f0c3ecfae1a1b 
>   src/launcher/fetcher.cpp f85b118fb19cf9d4563f89847a783be35067e815 
>   src/slave/containerizer/fetcher.cpp 33dfcade6beb53a5a6dbc41a8f3380f5cb30a161 
>   src/tests/fetcher_cache_tests.cpp 645dae208cb2b0aa2d2181d96eb1fd8893975430 
>   src/tests/fetcher_tests.cpp fb47706eb90ae5808bafe13c681d609a808b0c8e 
> 
> Diff: https://reviews.apache.org/r/45046/diff/
> 
> 
> Testing
> -------
> 
> There are two paths by which a file gets fetched to the executor sandbox: the without-cache
path, where the fetcher downloads the file directly from the specified URI, and the with-cache
path, where it copies it from the cache. In both cases, we verify that the file is saved to
the sandbox directory with the name specified by the "filename" field in the CommandInfo.URI
proto.
> 
> 
> Thanks,
> 
> Michael Browning
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message