mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joerg Schad <jo...@mesosphere.io>
Subject Re: Review Request 44554: Added agent HTTP authentication to the docs.
Date Sat, 19 Mar 2016 10:49:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44554/#review124398
-----------------------------------------------------------




docs/authentication.md (line 45)
<https://reviews.apache.org/r/44554/#comment186930>

    Does it make to create a 'Master and Slave Options' section similar to configuration.md.
    Otherwise we end up repeating many flags in both sections.



docs/authentication.md (line 85)
<https://reviews.apache.org/r/44554/#comment186928>

    Do we have documentation for basic authenticator?



docs/configuration.md (line 448)
<https://reviews.apache.org/r/44554/#comment186931>

    Shouldn't this flag now simply move up to the shared "Master and Slave Options
    These options can be supplied to both masters and slaves." section instead of introducing
a duplicated flag in the slave section (see comment below).



docs/configuration.md (line 535)
<https://reviews.apache.org/r/44554/#comment186933>

    same here (see authenticate_http). This should move to shared Master/Slave section instead
of duplicating it in both sections.



docs/configuration.md (line 878)
<https://reviews.apache.org/r/44554/#comment186929>

    See comment above about moving this flag to the shared master/agent section.



docs/configuration.md (line 1261)
<https://reviews.apache.org/r/44554/#comment186932>

    This flag should also move to the shared "Master and Slave Options" section instead of
duplicating it.



docs/configuration.md (line 1274)
<https://reviews.apache.org/r/44554/#comment186934>

    dito.


- Joerg Schad


On March 18, 2016, 7:30 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44554/
> -----------------------------------------------------------
> 
> (Updated March 18, 2016, 7:30 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4850
>     https://issues.apache.org/jira/browse/MESOS-4850
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added agent HTTP authentication to the docs.
> 
> 
> Diffs
> -----
> 
>   docs/authentication.md e7c0bf3ed331411f607e7622419f14853006a480 
>   docs/configuration.md d10fa2e7fc7c477de2f0e30e10da6d817ecbf404 
>   docs/home.md fd7794f56b4a95268dbb82288d99cab19a89f5cd 
> 
> Diff: https://reviews.apache.org/r/44554/diff/
> 
> 
> Testing
> -------
> 
> Viewed with the Mesos website container: https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message