mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tomasz Janiszewski <jani...@gmail.com>
Subject Re: Review Request 45057: Made `unzip` overwrite existing files without prompting.
Date Sat, 19 Mar 2016 10:25:07 GMT


> On March 19, 2016, 7:08 a.m., haosdent huang wrote:
> >

In fact zipfile containg duplicates is valid zip. There is a problem with extracting files,
becouse `unzip` will prompt user how to deal with it. Forcing overwrite makes unzip works
like `tar` and `gunzip`. When zip file is invalid or somehow broken (e.g., readable but CRC
doesn't match) unzip will do extraction but return non zero. I added test case for it.


- Tomasz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45057/#review124380
-----------------------------------------------------------


On March 18, 2016, 10:29 p.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45057/
> -----------------------------------------------------------
> 
> (Updated March 18, 2016, 10:29 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4885
>     https://issues.apache.org/jira/browse/MESOS-4885
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made `unzip` overwrite existing files without prompting.
> 
> 
> Diffs
> -----
> 
>   src/launcher/fetcher.cpp f85b118fb19cf9d4563f89847a783be35067e815 
>   src/tests/fetcher_tests.cpp fb47706eb90ae5808bafe13c681d609a808b0c8e 
> 
> Diff: https://reviews.apache.org/r/45057/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message