mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 45070: Clean up libprocess gtest macros (MESOS-4112).
Date Sat, 19 Mar 2016 08:57:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45070/#review124386
-----------------------------------------------------------



Patch looks great!

Reviews applied: [45070]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1
MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 19, 2016, 2:09 a.m., Yong Tang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45070/
> -----------------------------------------------------------
> 
> (Updated March 19, 2016, 2:09 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4112
>     https://issues.apache.org/jira/browse/MESOS-4112
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This review request tries to clean up gtest macros in libprocess.
> The following items have been done:
> 1. AWAIT_EQ_FOR have be added for completeness.
> 2. Missing equivalents of EXPECT_TRUE/EXPECT_FALSE have been added:
>     a) AWAIT_ASSERT_TRUE_FOR
>     b) AWAIT_ASSERT_TRUE
>     c) AWAIT_ASSERT_FALSE_FOR
>     d) AWAIT_ASSERT_FALSE
>     e) AWAIT_EXPECT_TRUE_FOR
>     f) AWAIT_EXPECT_FALSE_FOR
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/gtest.hpp 049152c0535c78e6986346610735d301fb6876bc

> 
> Diff: https://reviews.apache.org/r/45070/diff/
> 
> 
> Testing
> -------
> 
> make check (Ubuntu 14.04)
> 
> 
> Thanks,
> 
> Yong Tang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message