mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.
Date Fri, 18 Mar 2016 21:01:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44287/#review124259
-----------------------------------------------------------



Sorry for the delay...

As Vinod suggested, you might want to consider reaching out to another shepherd (as far as
I can tell, BenH is not likely to have time in the foreseeable future).  (And in case you
don't know, I'm not a shepherd :)


include/mesos/master/contender.hpp (line 44)
<https://reviews.apache.org/r/44287/#comment186718>

    Nit: Use backticks instead of single-quotes for references to the code in comments.
    
    Ditto for flags and objects (like `ZookeeperMasterContender`)



include/mesos/master/contender.hpp (line 45)
<https://reviews.apache.org/r/44287/#comment186734>

    Note that flags are not limited to "command line invocations".  For example, you can specify
an environment variable `MESOS_ZK=...` to get the same effect as `--zk`.



include/mesos/master/contender.hpp (lines 63 - 64)
<https://reviews.apache.org/r/44287/#comment186746>

    I'd take out the bit about "key-value pairs".  Since the `Parameters` are parsed as protobuf,
the JSON ends up looking like:
    ```
    "parameters" : [
      {
        "key" : "foo",
        "value" : "bar"
      }, {
        "key" : "other_key",
        "value" : "other_value"
      }
    ]
    ```
    
    Also, extra newline.


- Joseph Wu


On March 17, 2016, 5:29 p.m., Anurag Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44287/
> -----------------------------------------------------------
> 
> (Updated March 17, 2016, 5:29 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-4610
>     https://issues.apache.org/jira/browse/MESOS-4610
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MasterContender and MasterDetector abstract classes can be subclassed by
> user-provided classes to allow for arbitrary contender/detector implementations.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/contender.hpp PRE-CREATION 
>   include/mesos/master/detector.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44287/diff/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/44670/.
> 
> 
> Thanks,
> 
> Anurag Singh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message