mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 44229: Added upgrade testing script.
Date Fri, 18 Mar 2016 20:52:21 GMT


> On March 16, 2016, 12:43 a.m., Vinod Kone wrote:
> > support/test-upgrade.py, line 63
> > <https://reviews.apache.org/r/44229/diff/1/?file=1275758#file1275758line63>
> >
> >     s/persistent-volume-framework/test-framework/ ?
> >     
> >     actuallly we should be testing the long-lived-framework instead of test-framework.
but that needs updating the long lived framework to abort on un-expected state changes (e.g.,
TASK_FAILED received instead of TASK_FINISHED).

Sorry for the delay on this review - I've been investigating the `test-framework` and trying
to get it working with the upgrade script. I originally switched to the `persistent-volume-framework`
because it worked straight away, whereas the `test-framework` is failing, presumably because
of something done in `test_framework_test.sh` that isn't done in this upgrade script.

It might be good for this script to run multiple test frameworks and allow them to be disabled;
if we alter example frameworks or add new ones, this would be helpful when testing upgrades
across versions with incompatible frameworks.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44229/#review123800
-----------------------------------------------------------


On March 16, 2016, 12:18 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44229/
> -----------------------------------------------------------
> 
> (Updated March 16, 2016, 12:18 a.m.)
> 
> 
> Review request for mesos, Niklas Nielsen and Vinod Kone.
> 
> 
> Bugs: MESOS-2372
>     https://issues.apache.org/jira/browse/MESOS-2372
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added upgrade testing script.
> 
> 
> Diffs
> -----
> 
>   support/test-upgrade.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44229/diff/
> 
> 
> Testing
> -------
> 
> This script is copied from @nnielsen, original patch can be found here: https://reviews.apache.org/r/31645/
> 
> To test, build two different versions of Mesos in two different directories. Then do:
> `support/test-upgrade.py --prev=/path/to/earlier/version --next=/path/to/later/version`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message