mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 44978: Windows: Fixed `fs::list` to be more compliant with POSIX version.
Date Fri, 18 Mar 2016 19:47:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44978/#review124264
-----------------------------------------------------------




3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (line 181)
<https://reviews.apache.org/r/44978/#comment186730>

    Not yours, but these should be `EXPECT_*` rather than `ASSERT_*`.
    
    The `ASSERT_SOME` test above makes sense since if that condition is violated, then `allFiles.get()`
is invalid. But this test does not have impact on the validity of the subsequent tests, and
shouldn't end the test case.
    
    Furthermore, we should use:
    
    ```cpp
    EXPECT_EQ(3u, allFiles.get().size());`
    ```
    
    In order to get more meaningful output if/when tests fail.
    
    Do you mind fixing them in this review please?



3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (line 186)
<https://reviews.apache.org/r/44978/#comment186731>

    ```cpp
      EXPECT_EQ(1u, jpgFiles.get().size());
    ```



3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (line 191)
<https://reviews.apache.org/r/44978/#comment186732>

    ```cpp
      EXPECT_EQ(2u, testTxtFiles.get().size());
    ```



3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (line 196)
<https://reviews.apache.org/r/44978/#comment186733>

    ```cpp
      EXPECT_EQ(0u, noFiles.get().size());
    ```


- Michael Park


On March 18, 2016, 12:12 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44978/
> -----------------------------------------------------------
> 
> (Updated March 18, 2016, 12:12 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere,
Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Fixed `fs::list` to be more compliant with POSIX version.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/fs.hpp 7dace7d579c1b18afcf2278f9689b205cf57877f

>   3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83

> 
> Diff: https://reviews.apache.org/r/44978/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message