mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 44435: Fixed a bug that causes the task stuck in staging state.
Date Fri, 18 Mar 2016 19:00:35 GMT


> On March 18, 2016, 7 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, line 674
> > <https://reviews.apache.org/r/44435/diff/1/?file=1282188#file1282188line674>
> >
> >     Thanks for catching the bug. I think this is a pretty bad bug which might worth
cutting 0.28.1.
> >     
> >     Your fix for this issue does reveal another issue in the code: It's possible
that we will call provisioner->destroy while provisioner->provision is in progress.
This could cause leaking of the provisioned directory. I'll create another ticket for that.
Can you add a TODO here?
> >     
> >     For this patch, can you add a comment here stating why you need to set it to
be a ready future here? E.g.:
> >     ```
> >     We need to set the 'launchInfos' to be a ready future initially before we starting
calling isolator->prepare() because otherwise, the destroy will wait forever trying to
wait for this future to be ready, which it never will.
> >     ```

Please include the ticket number in the TODO.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44435/#review124251
-----------------------------------------------------------


On March 6, 2016, 9:23 p.m., Shuai Lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44435/
> -----------------------------------------------------------
> 
> (Updated March 6, 2016, 9:23 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4878
>     https://issues.apache.org/jira/browse/MESOS-4878
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed a bug that causes the task stuck in staging state.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp af3ff5750649497d8852b4761c78d4cae5455a02

>   src/tests/containerizer/mesos_containerizer_tests.cpp 15f0f93d2e5c19a22f6cc4a71a7d94be4aaec2c1

> 
> Diff: https://reviews.apache.org/r/44435/diff/
> 
> 
> Testing
> -------
> 
> - Added a new test `"MesosContainerizerProvisionerTest.ProvisionFailed"`
> - make check
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message