mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 44851: Renamed an allocator metric.
Date Fri, 18 Mar 2016 16:08:18 GMT


> On March 18, 2016, 3:59 a.m., Guangya Liu wrote:
> > src/master/allocator/mesos/metrics.hpp, lines 40-42
> > <https://reviews.apache.org/r/44851/diff/2/?file=1302462#file1302462line40>
> >
> >     Can you please file a JIRA to desribe the problem? Not quite catch why do we
need to add a metrics in 0.29 and then remove it in 0.30?
> >     
> >     Or else can you please update the comments to be more clear?

Follow-up commits will add more allocator-specific metrics. Since they are all specific to
the mesos allocator we should properly communicate that in their names.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44851/#review124143
-----------------------------------------------------------


On March 17, 2016, 6:41 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44851/
> -----------------------------------------------------------
> 
> (Updated March 17, 2016, 6:41 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since allocators can be replaced with a custom module instead use a
> name clearly communicating that the metrics reported here are related
> to the default (hierarchical) allocator.
> 
> For backwards compatibility we continue to support the old metrics
> name.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/metrics.hpp d04e9a11c77b6fb2d522608e3085f81f8a6657ca 
>   src/master/allocator/mesos/metrics.cpp 46dd7f7b3d8d49c59b42e789fe5dcd49f1693ace 
> 
> Diff: https://reviews.apache.org/r/44851/diff/
> 
> 
> Testing
> -------
> 
> check make check (OS X, clang-trunk) here and with later patches using other allocator
metrics.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message